Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong translation in delete_confirmation.html #1049

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

jTiKey
Copy link
Contributor

@jTiKey jTiKey commented Feb 22, 2024

Fix the translation strings used for the button. Otherwise, the translation won't work.
before:
image
after:
image

Fix the translation strings used for the button. Otherwise, the translation won't work.
@jTiKey jTiKey changed the title Fix translation not working in delete_confirmation.html Fix wrong translation nin delete_confirmation.html Feb 22, 2024
@jTiKey jTiKey changed the title Fix wrong translation nin delete_confirmation.html Fix wrong translation in delete_confirmation.html Feb 22, 2024
@sehmaschine sehmaschine merged commit 6e6144b into sehmaschine:master Mar 13, 2024
atodorov added a commit to atodorov/django-grappelli that referenced this pull request Apr 26, 2024
same as in sehmaschine#1049,

while Django's own templates use this new apostrophe character:
https://github.com/django/django/blob/main/django/contrib/admin/templates/admin/delete_selected_confirmation.html#L42

their actual translation characters are a mess with a mix and match
between apostrophes and languages. The `en` language file however
matches the templates:
https://github.com/django/django/blob/main/django/contrib/admin/locale/en/LC_MESSAGES/django.po#L609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants