-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ledger version to support nano s #1156
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1156 +/- ##
==========================================
- Coverage 63.93% 63.83% -0.11%
==========================================
Files 254 256 +2
Lines 16234 16599 +365
==========================================
+ Hits 10380 10596 +216
- Misses 5349 5496 +147
- Partials 505 507 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me with my ledger nano X
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds to the keychain but bank sends don't work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Describe your changes and provide context
seid doesn't work with nano s. See cosmos/gaia#1573
Note this lib is used by other main chains:
Testing performed to validate your change
@codebycarson tested, also asked stakecito (reporter of issue) to confirm it works