Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ledger version to support nano s #1156

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Bump ledger version to support nano s #1156

merged 2 commits into from
Nov 30, 2023

Conversation

philipsu522
Copy link
Contributor

@philipsu522 philipsu522 commented Nov 27, 2023

Describe your changes and provide context

seid doesn't work with nano s. See cosmos/gaia#1573
Note this lib is used by other main chains:

Testing performed to validate your change

@codebycarson tested, also asked stakecito (reporter of issue) to confirm it works

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #1156 (9369059) into main (c071491) will decrease coverage by 0.11%.
Report is 46 commits behind head on main.
The diff coverage is 67.62%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1156      +/-   ##
==========================================
- Coverage   63.93%   63.83%   -0.11%     
==========================================
  Files         254      256       +2     
  Lines       16234    16599     +365     
==========================================
+ Hits        10380    10596     +216     
- Misses       5349     5496     +147     
- Partials      505      507       +2     
Files Coverage Δ
aclmapping/dex/mappings.go 100.00% <100.00%> (ø)
aclmapping/oracle/mappings.go 100.00% <100.00%> (ø)
aclmapping/tokenfactory/mappings.go 100.00% <100.00%> (ø)
app/antedecorators/gasless.go 88.72% <100.00%> (ø)
app/test_helpers.go 48.53% <ø> (ø)
app/upgrades.go 40.74% <100.00%> (+20.74%) ⬆️
oracle/price-feeder/config/config.go 74.07% <ø> (+4.41%) ⬆️
oracle/price-feeder/oracle/filter.go 91.42% <100.00%> (+0.90%) ⬆️
oracle/price-feeder/oracle/provider/crypto.go 73.12% <100.00%> (ø)
oracle/price-feeder/oracle/util.go 97.50% <100.00%> (+5.39%) ⬆️
... and 51 more

... and 2 files with indirect coverage changes

Copy link
Contributor

@codebycarson codebycarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me with my ledger nano X

Copy link
Contributor

@codebycarson codebycarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds to the keychain but bank sends don't work

Copy link
Contributor

@codebycarson codebycarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@philipsu522 philipsu522 enabled auto-merge (squash) November 30, 2023 01:26
@philipsu522 philipsu522 merged commit e576d3d into main Nov 30, 2023
36 checks passed
@philipsu522 philipsu522 deleted the ledger-nano branch November 30, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants