Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EVM] Add association error metric #1727

Merged
merged 24 commits into from
Jun 12, 2024
Merged

[EVM] Add association error metric #1727

merged 24 commits into from
Jun 12, 2024

Conversation

stevenlanders
Copy link
Contributor

Describe your changes and provide context

  • emit metrrics for when an association error occurs
  • this will primarily affect estimateGas (these will typically prevent txs being sent)

Testing performed to validate your change

  • local and lower environment metrics

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 64.17910% with 24 lines in your changes missing coverage. Please review.

Project coverage is 60.95%. Comparing base (6353441) to head (45a91d4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1727      +/-   ##
==========================================
+ Coverage   60.67%   60.95%   +0.27%     
==========================================
  Files         370      371       +1     
  Lines       27437    27466      +29     
==========================================
+ Hits        16648    16742      +94     
+ Misses       9649     9580      -69     
- Partials     1140     1144       +4     
Files Coverage Δ
evmrpc/utils.go 66.14% <100.00%> (+0.81%) ⬆️
precompiles/common/precompiles.go 23.28% <100.00%> (+8.58%) ⬆️
precompiles/distribution/distribution.go 73.09% <100.00%> (+0.13%) ⬆️
precompiles/gov/gov.go 61.76% <100.00%> (+9.28%) ⬆️
x/evm/ante/preprocess.go 75.00% <100.00%> (+0.08%) ⬆️
x/evm/keeper/evm.go 66.40% <100.00%> (+10.05%) ⬆️
x/evm/types/errors.go 100.00% <100.00%> (ø)
precompiles/ibc/ibc.go 45.34% <75.00%> (+0.15%) ⬆️
precompiles/staking/staking.go 63.57% <83.33%> (+0.26%) ⬆️
precompiles/wasmd/wasmd.go 61.96% <50.00%> (+0.09%) ⬆️
... and 2 more

... and 3 files with indirect coverage changes

@stevenlanders stevenlanders merged commit 92f1773 into main Jun 12, 2024
49 checks passed
@stevenlanders stevenlanders deleted the add-link-error-metric branch June 12, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants