Only emit cosmos events if no error in precompiles #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1744 +/- ##
==========================================
+ Coverage 60.63% 60.88% +0.24%
==========================================
Files 372 372
Lines 27024 26838 -186
==========================================
- Hits 16386 16339 -47
+ Misses 9539 9406 -133
+ Partials 1099 1093 -6
|
udpatil
approved these changes
Jun 24, 2024
codchen
changed the title
codchen
force-pushed
the
partial-rollback-events
branch
from
c11fdb4 to
ef80495
Compare
codchen
force-pushed
the
partial-rollback-events
branch
from
5212893 to
382466f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Although we recently made a change to mark EVM txs that encountered as failed on cosmos level, so that events emit by any cosmwasm contract as part of the EVM tx won't be persisted, this does not prevent similar issue from happening if the cosmwasm call error is caught and handled by the invoking solidity contract. In such cases, events from the failed CW call would still emit, which is not desired. The impact of this depends on whether there is any application depending on CW events for mission-critical flows, which is unclear right now.
UPDATE: in order to have this treatment for all modules, not just wasm, this PR included a rather large refactor to precompiles so that common logic (like the event logic introduced by this PR) can go into a base class. No behavioral change is expected from this refactor, so existing tests should still hold (aside from necessary field/struct name changes)
Testing performed to validate your change
unit tests