[EVM] subscribe logs empty params crash #1779
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Our websocket RPC would crash when given this empty filter where we don't filter on anything so it should return all logs:
{"jsonrpc":"2.0","id": 2, "method": "eth_subscribe", "params": ["logs"]}
. This PR creates an empty filter if the filter given as input from the rpc is nil.Testing performed to validate your change
unit tests, manual testing locally.