Update excessBlobGas and BlobBaseFee to fix simulate evmcontext #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| BaseFee: b.keeper.GetBaseFeePerGas(b.ctxProvider(LatestCtxHeight)).BigInt(), | ||
| GasLimit: b.config.GasCap, | ||
| Time: uint64(time.Now().Unix()), | ||
| ExcessBlobGas: &zeroExcessBlobGas, |
Check warning
Code scanning / CodeQL
Calling the system time Warning
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1782 +/- ##
==========================================
+ Coverage 60.85% 60.87% +0.02%
==========================================
Files 257 257
Lines 22488 22490 +2
==========================================
+ Hits 13684 13690 +6
+ Misses 7839 7835 -4
Partials 965 965
|
codchen
approved these changes
Jul 25, 2024
udpatil
force-pushed
the
fix-simulate-context
branch
from
403ed98 to
60d97a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This modifies the EVM context created in keeper to use
1as the blob base fee and also updates the evmrpc simulate getHeader to return 0 for excess blob gas so that trace block involving the blobbasefee opcode doesn't fail.Testing performed to validate your change
Added hardhat test to verify opcode succeeds