Remove token factory config #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1971 +/- ##
==========================================
+ Coverage 61.71% 61.85% +0.14%
==========================================
Files 264 263 -1
Lines 23498 23503 +5
==========================================
+ Hits 14501 14538 +37
+ Misses 7985 7951 -34
- Partials 1012 1014 +2
|
mj850
reviewed
Dec 4, 2024
proto/tokenfactory/params.proto
Outdated
| @@ -4,4 +4,6 @@ package seiprotocol.seichain.tokenfactory; | |||
| option go_package = "github.com/sei-protocol/sei-chain/x/tokenfactory/types"; | |||
|
|
|||
| // Params defines the parameters for the tokenfactory module. | |||
| message Params {} | |||
| message Params { | |||
| int32 denom_allowlist_max_size = 1; | |||
There was a problem hiding this comment.
Nit: consider using uint32 for easier validation
| @@ -51,6 +51,10 @@ func (suite *KeeperTestSuite) TestMsgCreateDenom() { | |||
| } | |||
|
|
|||
| func (suite *KeeperTestSuite) TestCreateDenom() { | |||
| largeAllowList := make([]string, 2001) | |||
| for i := 0; i < 2001; i++ { | |||
There was a problem hiding this comment.
Nit: Should we make this size (2001) relative to the MaxAllowListSize stored in params? (Ie MaxAlowListSize + 1).
| @@ -158,6 +156,10 @@ func (suite *KeeperTestSuite) TestCreateDenom() { | |||
| } | |||
|
|
|||
| func (suite *KeeperTestSuite) TestUpdateDenom() { | |||
| largeAllowList := make([]string, 2001) | |||
There was a problem hiding this comment.
Similar comment as above wrt making this exceed the MaxAllowListSize param
x/tokenfactory/keeper/keeper.go
Outdated
| @@ -86,3 +81,9 @@ func (k Keeper) CreateModuleAccount(ctx sdk.Context) { | |||
| moduleAcc := authtypes.NewEmptyModuleAccount(types.ModuleName, authtypes.Minter, authtypes.Burner) | |||
| k.accountKeeper.SetModuleAccount(ctx, moduleAcc) | |||
| } | |||
|
|
|||
| func (k Keeper) GetDenomAllowListMaxSize(ctx sdk.Context) int32 { | |||
| var demomAllowListMaxSize int32 | |||
x/tokenfactory/types/params.go
Outdated
| paramtypes "github.com/cosmos/cosmos-sdk/x/params/types" | ||
| ) | ||
|
|
||
| // ParamTable for tokenfactory module. | ||
| const DenomAllowListMaxSize = 2000 |
There was a problem hiding this comment.
DefaultDenomAllowListMaxSize? To make it clearer that this is just the default and might be changed by future gov proposals
There was a problem hiding this comment.
renamed and added comment
mj850
approved these changes
Dec 4, 2024
philipsu522
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Move allowlist size app setting to gov params.
Testing performed to validate your change