Improve cachekv write performance #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #388 +/- ##
==========================================
- Coverage 54.81% 54.80% -0.01%
==========================================
Files 622 622
Lines 52177 52168 -9
==========================================
- Hits 28599 28590 -9
Misses 21495 21495
Partials 2083 2083
|
philipsu522
approved these changes
Dec 29, 2023
udpatil
reviewed
Dec 29, 2023
| @@ -135,18 +135,9 @@ func (store *Store) Write() { | |||
| // Clear the cache using the map clearing idiom | |||
| // and not allocating fresh objects. | |||
| // Please see https://bencher.orijtech.com/perfclinic/mapclearing/ | |||
| store.cache.Range(func(key, value any) bool { | |||
There was a problem hiding this comment.
do these maps no longer behave in the idiomatic way? I gues that makes sense as we migrated from native go maps to sync maps, but just want to confirm
There was a problem hiding this comment.
Yeah, there's also a mutex to protect the writes
udpatil
approved these changes
Dec 29, 2023
stevenlanders
approved these changes
Dec 29, 2023
store/cachekv/store.go
Outdated
| @@ -135,18 +135,9 @@ func (store *Store) Write() { | |||
| // Clear the cache using the map clearing idiom | |||
There was a problem hiding this comment.
(i think this comment can probably go away now - LGTM 👍)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This PR avoid the several O(N) operations to clear up the maps. Instead of looping through each item and delete them, it will be much more efficient to just reset to a new map.
Testing performed to validate your change
Tested in loadtest cluster and get performance improved (3ms -> 0.1ms)