fix #43

seibert-media · Apr 15, 2015 · 36d042a · 36d042a
1 parent d8d1835
commit 36d042a
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/src/teamvault/apps/secrets/models.py b/src/teamvault/apps/secrets/models.py
@@ -152,7 +152,11 @@ def approve(self, reviewer):
         self.secret.allowed_users.add(self.requester)
 
         other_reviewers = list(self.reviewers.all())
-        other_reviewers.remove(reviewer)
+        try:
+            other_reviewers.remove(reviewer)
+        except ValueError:
+            # review by other superuser
+            pass
 
         send_mail(
             other_reviewers + [self.requester],
@@ -225,7 +229,11 @@ def reject(self, reviewer, reason=None):
         self.save()
 
         other_reviewers = list(self.reviewers.all())
-        other_reviewers.remove(reviewer)
+        try:
+            other_reviewers.remove(reviewer)
+        except ValueError:
+            # review by other superuser
+            pass
 
         send_mail(
             other_reviewers + [self.requester],