Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find alternative package for netifaces #1384

Closed
zhengfeihe opened this issue May 5, 2024 · 12 comments · Fixed by #1489
Closed

Find alternative package for netifaces #1384

zhengfeihe opened this issue May 5, 2024 · 12 comments · Fixed by #1489

Comments

@zhengfeihe
Copy link
Contributor

zhengfeihe commented May 5, 2024

I found netifaces package is no longer under maintained since python3.9 , detailed info here: al45tair/netifaces#78. Some other projects have moved to using other packages, eg psutil: ros2/ros2cli#875

Maybe we can also move to using other under maintained, reliable packages as well.

@zhengfeihe
Copy link
Contributor Author

I'd like to work on this after I finish my current pr.

@seladb
Copy link
Owner

seladb commented Jun 15, 2024

@zhengfeihe are you still planning to work on this?

@seladb
Copy link
Owner

seladb commented Jun 15, 2024

By the way, there is this project: https://github.com/SamuelYvon/netifaces-2

But I'm not sure it'll work well on FreeBSD: SamuelYvon/netifaces-2#36

@tigercosmos
Copy link
Collaborator

FreeBSD can be treated as a special case, I guess.

@seladb
Copy link
Owner

seladb commented Jun 15, 2024

FreeBSD can be treated as a special case, I guess.

Maybe... or we can try to fix this package to work with FreeBSD, or we can choose another library 🙂

@zhengfeihe
Copy link
Contributor Author

@zhengfeihe are you still planning to work on this?

Yes.. Just got delayed onmy current pr. I will start working on this soon.

@tigercosmos
Copy link
Collaborator

@zhengfeihe I think you might want to work on this, going to assign you.

@zhengfeihe
Copy link
Contributor Author

@zhengfeihe I think you might want to work on this, going to assign you.

Thanks! I already started.

@tigercosmos
Copy link
Collaborator

As we need to support Ubuntu24.04, this issue seems to become critical at the moment.
Some error happens in the CI of the PR #1486: Log

@tigercosmos
Copy link
Collaborator

@zhengfeihe please confirm if you can submit the PR for this by today; otherwise, I am sorry that I have to unassign you and take over this issue.

@zhengfeihe
Copy link
Contributor Author

@zhengfeihe please confirm if you can submit the PR for this by today; otherwise, I am sorry that I have to unassign you and take over this issue.

I will submit the pr by the end of the day.

@Dimi1010 Dimi1010 linked a pull request Aug 9, 2024 that will close this issue
@tigercosmos
Copy link
Collaborator

addressed in #1489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants