support ubuntu 24 in CI #1486
support ubuntu 24 in CI #1486
Conversation
|
@tigercosmos we need to install venv on all Linux containers to make it work. In Ubuntu the package is |
I see, let me figure out. |
|
blocking by #1384 due to: |
This reverts commit 5f80c36.
This reverts commit 7b18e8b.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1486 +/- ##
==========================================
- Coverage 82.91% 82.91% -0.01%
==========================================
Files 273 273
Lines 46272 46272
Branches 9441 9259 -182
==========================================
- Hits 38368 38366 -2
- Misses 7082 7102 +20
+ Partials 822 804 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@seladb ready for review. |
| @@ -32,6 +32,7 @@ jobs: | |||
| apk update && apk add cppcheck python3-dev | |||
| python3 -m pip install cmake-format clang-format==18.1.6 | |||
|
|
|||
| # TODO: investigate how to run pre-commit with `venv` | |||
There was a problem hiding this comment.
Not related with this PR directly but, it is possible to use pre-commit.ci but we should remove cppcheck and clang-format from pre-commit since they require pre-installed binaries.
| ${{ matrix.python }} -m pip install -U pip | ||
| ${{ matrix.python }} -m pip install -r ci/run_tests/requirements.txt | ||
| ${{ matrix.python }} ci/run_tests/run_tests.py --interface eth0 ${{ matrix.test-flags }} | ||
| python3 -m venv ./venv |
There was a problem hiding this comment.
nit: Maybe move this line to it's own step? It looks weird to me that the venv is created inside the 'Test PCPP' step but the following steps also depend on it.
There was a problem hiding this comment.
Sure. Moved it to a step.
.github/workflows/build_and_test.yml
Outdated
| if: ${{ matrix.host-arch == matrix.arch }} | ||
| run: | | ||
| python -m pip install -U pip | ||
| python -m venv ./venv | ||
| source ./venv/bin/activate | ||
| python -m pip install -r ci/run_tests/requirements.txt | ||
| python ci/run_tests/run_tests.py --interface en0 | ||
|
|
||
| - name: Test Examples | ||
| if: ${{ matrix.host-arch == matrix.arch }} | ||
| run: | | ||
| cd Tests/ExamplesTest | ||
| python -m pip install -U pip | ||
| python -m pip install -r requirements.txt | ||
| python -m pytest --interface en0 --use-sudo --root-path=../../Dist/examples_bin |
There was a problem hiding this comment.
Why does the first step use 'venv' and the second doesn't?
venvfor pip installation