Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay codecov report until most of CI is done #1203

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

seladb
Copy link
Owner

@seladb seladb commented Sep 18, 2023

When a PR is running codecov always shows as failing until enough reports are being uploaded.
This PR should fix it.

NOTE: we currently have 18 jobs, but report uploads sometimes fail so setting the threshold to 16

Here are a few references:
https://docs.codecov.com/docs/notifications#preventing-notifications-until-after-n-builds
https://community.codecov.com/t/github-status-notification-isnt-delayed-should-wait-all-ci-jobs-to-finish/3708/9

@seladb seladb requested a review from egecetin September 18, 2023 08:38
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #1203 (0947730) into dev (6e2e88e) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #1203      +/-   ##
==========================================
- Coverage   81.67%   81.63%   -0.05%     
==========================================
  Files         157      157              
  Lines       20180    20180              
  Branches     7624     7624              
==========================================
- Hits        16483    16473      -10     
- Misses       3073     3086      +13     
+ Partials      624      621       -3     
Flag Coverage Δ
alpine317 68.53% <ø> (ø)
centos7 71.91% <ø> (-0.01%) ⬇️
fedora37 68.36% <ø> (ø)
macos-11 0.00% <ø> (-60.04%) ⬇️
macos-12 0.00% <ø> (-60.16%) ⬇️
macos-ventura 60.11% <ø> (ø)
mingw32 68.75% <ø> (ø)
mingw64 68.77% <ø> (ø)
npcap 82.09% <ø> (-0.02%) ⬇️
ubuntu1804 72.13% <ø> (ø)
ubuntu2004 68.31% <ø> (-0.90%) ⬇️
ubuntu2204 68.14% <ø> (ø)
ubuntu2204-icpx 59.16% <ø> (ø)
unittest 81.63% <ø> (-0.05%) ⬇️
windows-2019 82.10% <ø> (-0.02%) ⬇️
windows-2022 82.12% <ø> (ø)
winpcap 82.09% <ø> (+0.01%) ⬆️
zstd 71.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 23 files with indirect coverage changes

@egecetin egecetin merged commit b6d1801 into dev Sep 18, 2023
35 checks passed
@egecetin egecetin deleted the delay-codecov-report branch September 18, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants