Add PR trigger for package workflow #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1302 +/- ##
==========================================
- Coverage 82.38% 82.38% -0.01%
==========================================
Files 163 163
Lines 20932 20932
Branches 7898 7898
==========================================
- Hits 17245 17244 -1
- Misses 3017 3021 +4
+ Partials 670 667 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
First time see this.. It would be helpful if you could add some explanation and comments. |
|
@clementperon @seladb Do you have any idea why freebsd fails? I'm not sure I catch up with latest FreeBSD PRs |
This was referenced Feb 2, 2024
clementperon
reviewed
Feb 3, 2024
clementperon
reviewed
Feb 3, 2024
|
@egecetin During the update to freebsd-vm@v1 we should have update the runs-on: macos-12 to runs-on: ubuntu-latest |
clementperon
approved these changes
Feb 4, 2024
seladb
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the package workflow is modified in a PR, workflow should run for testing. With this PR, if the package.yml modified, packaging workflow triggered without uploading the artifacts.