Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from CentOS to RedHat Entreprise Linux #1307

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

clementperon
Copy link
Collaborator

No description provided.

@clementperon clementperon requested a review from egecetin February 5, 2024 20:26
@clementperon clementperon requested a review from seladb as a code owner February 5, 2024 20:26
@clementperon clementperon changed the base branch from master to dev February 5, 2024 20:26
@egecetin
Copy link
Collaborator

egecetin commented Feb 5, 2024

This should also be updated,

elseif("${DISTRO_ID}" STREQUAL "centos")

@clementperon
Copy link
Collaborator Author

clementperon commented Feb 5, 2024

This should also be updated,

elseif("${DISTRO_ID}" STREQUAL "centos")

@egecetin for the moment this part of CMake is unused but I have added RHEL to not forget it.
Also we can keep "centos" just in case a guy try to package for centos on its machine

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba336be) 70.30% compared to head (e9843f1) 82.38%.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev    #1307       +/-   ##
===========================================
+ Coverage   70.30%   82.38%   +12.07%     
===========================================
  Files         160      163        +3     
  Lines       13206    20932     +7726     
  Branches     5006     7898     +2892     
===========================================
+ Hits         9284    17244     +7960     
- Misses       2140     3013      +873     
+ Partials     1782      675     -1107     
Flag Coverage Δ
alpine317 72.41% <ø> (?)
macos-11 61.34% <ø> (?)
macos-12 61.40% <ø> (?)
mingw32 70.24% <ø> (?)
mingw64 70.28% <ø> (-0.02%) ⬇️
npcap 83.35% <ø> (?)
rhel93 72.45% <ø> (?)
ubuntu1804 74.80% <ø> (?)
ubuntu2004 72.27% <ø> (?)
ubuntu2204 72.19% <ø> (?)
ubuntu2204-icpx 59.03% <ø> (?)
unittest 82.38% <ø> (+12.07%) ⬆️
windows-2019 83.39% <ø> (?)
windows-2022 83.34% <ø> (?)
winpcap 83.40% <ø> (?)
xdp 59.02% <ø> (?)
zstd 72.27% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@seladb seladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clementperon clementperon merged commit 7d806e8 into seladb:dev Feb 6, 2024
39 checks passed
@seladb
Copy link
Owner

seladb commented Feb 11, 2024

@clementperon we also need to update the documentation. I found a few places which need update:

* https://pcapplusplus.github.io/docs/next/install#github-release ([source](https://github.com/PcapPlusPlus/pcapplusplus.github.io/edit/master/docs/install/index.mdx))

* https://pcapplusplus.github.io/docs/next/platforms#-linux ([source](https://github.com/PcapPlusPlus/pcapplusplus.github.io/edit/master/docs/platforms.mdx))

* https://pcapplusplus.github.io/docs/next/quickstart#step-1---download-pcapplusplus ([source](https://github.com/PcapPlusPlus/pcapplusplus.github.io/edit/master/docs/quickstart.mdx))

@clementperon I updated the documentation in this PR: PcapPlusPlus/pcapplusplus.github.io#80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants