Fix LightPcapNg timestamp calculation #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigercosmos
reviewed
Aug 14, 2024
| @@ -422,7 +422,7 @@ int light_get_next_packet(light_pcapng_t *pcapng, light_packet_header *packet_he | |||
| timestamp = timestamp << 32; | |||
| timestamp += epb->timestamp_low; | |||
| uint64_t ticks_per_sec = pcapng->file_info->timestamp_ticks_per_second[epb->interface_id]; | |||
| uint64_t packet_secs = timestamp / ticks_per_sec; | |||
| uint64_t packet_secs = (ticks_per_sec != 0 ? timestamp / ticks_per_sec : 0); | |||
There was a problem hiding this comment.
Yes, I noticed it later... I added another commit with a fix: cde15ce
|
@tigercosmos Fuzz CI passes now 👍 It's nice to see that Fuzz CI found a bug! It was worth adding it @sashashura !! |
tigercosmos
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change introduced in this PR: #1514
Doesn't take into account cases where
ticks_per_secis zero. This PR fixes it