Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dead code from PcapRemoteDevice. #1538

Merged

Conversation

Dimi1010
Copy link
Collaborator

@Dimi1010 Dimi1010 commented Aug 15, 2024

ThreadStart, remoteDeviceCaptureThreadMain and getCaptureThreadStart are artifacts left over from previous refactor.

PcapLiveDevice currently handles all capture through pcap_dispatch in PcapLiveDevice::captureThreadMain.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.91%. Comparing base (b27e84f) to head (c1d0af8).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1538      +/-   ##
==========================================
+ Coverage   82.87%   82.91%   +0.03%     
==========================================
  Files         273      273              
  Lines       46296    46272      -24     
  Branches     9294     9287       -7     
==========================================
- Hits        38369    38366       -3     
+ Misses       7088     7083       -5     
+ Partials      839      823      -16     
Flag Coverage Δ
fedora39 74.56% <ø> (ø)
macos-12 80.88% <ø> (-0.01%) ⬇️
macos-13 80.30% <ø> (ø)
macos-14 80.23% <ø> (ø)
mingw32 71.43% <ø> (+0.03%) ⬆️
mingw64 71.43% <ø> (+0.03%) ⬆️
npcap 84.86% <ø> (+0.05%) ⬆️
rhel94 74.31% <ø> (-0.03%) ⬇️
ubuntu2004 57.88% <ø> (-0.03%) ⬇️
ubuntu2004-zstd 58.01% <ø> (-0.02%) ⬇️
ubuntu2204 74.27% <ø> (-0.01%) ⬇️
ubuntu2204-icpx 58.43% <ø> (+0.03%) ⬆️
unittest 82.91% <ø> (+0.03%) ⬆️
windows-2019 84.90% <ø> (+0.07%) ⬆️
windows-2022 84.91% <ø> (+0.08%) ⬆️
winpcap 84.88% <ø> (+0.08%) ⬆️
xdp 49.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tigercosmos tigercosmos merged commit c845b40 into seladb:dev Aug 16, 2024
39 checks passed
@Dimi1010 Dimi1010 deleted the refactor/live-dev-dead-code-removal branch August 16, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants