Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinPcapLiveDevice.h : explicit override #1592

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

Doekin
Copy link
Contributor

@Doekin Doekin commented Sep 28, 2024

fix error: 'getDeviceType' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override] when compiling with mingw-llvm 19.1.0

@Doekin Doekin requested a review from seladb as a code owner September 28, 2024 14:09
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.03%. Comparing base (3919812) to head (1c528d0).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1592   +/-   ##
=======================================
  Coverage   83.03%   83.03%           
=======================================
  Files         276      276           
  Lines       46689    46689           
  Branches     9328     9328           
=======================================
  Hits        38770    38770           
- Misses       7057     7062    +5     
+ Partials      862      857    -5     
Flag Coverage Δ
fedora40 74.58% <ø> (+0.04%) ⬆️
macos-12 81.01% <ø> (-0.01%) ⬇️
macos-13 80.44% <ø> (ø)
macos-14 80.36% <ø> (ø)
mingw32 70.46% <100.00%> (-0.02%) ⬇️
mingw64 70.41% <100.00%> (-0.05%) ⬇️
npcap 84.93% <ø> (-0.03%) ⬇️
rhel94 74.43% <ø> (+<0.01%) ⬆️
ubuntu2004 57.90% <ø> (ø)
ubuntu2004-zstd 58.03% <ø> (-0.03%) ⬇️
ubuntu2204 74.35% <ø> (ø)
ubuntu2204-icpx 58.56% <ø> (-0.01%) ⬇️
ubuntu2404 74.61% <ø> (+<0.01%) ⬆️
unittest 83.03% <100.00%> (ø)
windows-2019 84.98% <ø> (-0.02%) ⬇️
windows-2022 84.98% <ø> (-0.03%) ⬇️
winpcap 84.96% <ø> (ø)
xdp 49.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Pcap++/header/WinPcapLiveDevice.h Outdated Show resolved Hide resolved
Copy link
Collaborator

@tigercosmos tigercosmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@seladb seladb merged commit 1f52307 into seladb:dev Sep 30, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants