Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle exception of getLdapOperationAsn1Record() in getLdapOperationType() #1617

Merged
merged 1 commit into from
Oct 23, 2024
Merged

handle exception of getLdapOperationAsn1Record() in getLdapOperationType() #1617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion Packet++/src/LdapLayer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,17 @@ namespace pcpp

LdapOperationType LdapLayer::getLdapOperationType() const
{
return LdapOperationType::fromUintValue(getLdapOperationAsn1Record()->getTagType());
uint8_t tagType;
try
{
tagType = getLdapOperationAsn1Record()->getTagType();
}
catch (...)
{
tagType = LdapOperationType::Unknown;
}

return LdapOperationType::fromUintValue(tagType);
}

void LdapLayer::parseNextLayer()
Expand Down
Binary file added Tests/Fuzzers/RegressionTests/regression_samples/crash-exception-cast-constructed-record
View file
Open in desktop
Binary file not shown.
Loading