Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements such as use unique_ptr and C++ casting in Examples #1643

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

lumiZGorlic
Copy link
Contributor

in a few cpp and h files in Examples added some C++ casting and use of unique_ptr

@lumiZGorlic lumiZGorlic requested a review from seladb as a code owner November 15, 2024 23:28
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 66.00000% with 17 lines in your changes missing coverage. Please review.

Project coverage is 83.15%. Comparing base (3929558) to head (f292559).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
Examples/HttpAnalyzer/main.cpp 16.66% 5 Missing ⚠️
Examples/SSLAnalyzer/main.cpp 16.66% 5 Missing ⚠️
Examples/ArpSpoofing/main.cpp 0.00% 3 Missing ⚠️
Examples/PcapSplitter/main.cpp 84.21% 3 Missing ⚠️
Examples/Arping/main.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##              dev    #1643    +/-   ##
========================================
  Coverage   83.15%   83.15%            
========================================
  Files         277      277            
  Lines       48196    48189     -7     
  Branches     9991     9732   -259     
========================================
- Hits        40078    40073     -5     
+ Misses       7225     7220     -5     
- Partials      893      896     +3     
Flag Coverage Δ
fedora40 75.17% <73.68%> (+<0.01%) ⬆️
macos-13 80.66% <66.00%> (+<0.01%) ⬆️
macos-14 80.66% <66.00%> (+<0.01%) ⬆️
macos-15 80.63% <66.00%> (+<0.01%) ⬆️
mingw32 70.87% <ø> (-0.05%) ⬇️
mingw64 70.86% <ø> (-0.03%) ⬇️
npcap 85.29% <ø> (-0.02%) ⬇️
rhel94 75.02% <73.68%> (+<0.01%) ⬆️
ubuntu2004 58.60% <60.00%> (+<0.01%) ⬆️
ubuntu2004-zstd 58.72% <60.00%> (+<0.01%) ⬆️
ubuntu2204 74.94% <73.68%> (+<0.01%) ⬆️
ubuntu2204-icpx 61.44% <ø> (+0.03%) ⬆️
ubuntu2404 75.20% <73.68%> (-0.03%) ⬇️
unittest 83.15% <66.00%> (+<0.01%) ⬆️
windows-2019 85.33% <ø> (-0.01%) ⬇️
windows-2022 85.36% <ø> (-0.01%) ⬇️
winpcap 85.33% <ø> (+<0.01%) ⬆️
xdp 50.53% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@Dimi1010 Dimi1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution.

@seladb seladb merged commit feba0b7 into seladb:dev Nov 20, 2024
41 checks passed
@seladb
Copy link
Owner

seladb commented Nov 20, 2024

Thank you @lumiZGorlic for this contribution, much appreciated! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants