Refactor handle_command / no more switch statement #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that each command has a corresponding
handle_*
method, we don't really need a switch statement. We can just call the methods dynamically and rescue theNoMethodError
. This makes it easier to handle new commands in the future by simply adding a newhandle_*
method.I've also refactored how we break the main loop in the test scenario. Instead of returning
true
/false
, a command can explicitly return:break
.