Send version information in connection parameters #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires a change in the selective-ruby-rspec gem, which is not yet released. We'll need to consider how to handle this scenario so that we do not break the gem for users who are not using the latest version. Co-authored-by: Nate Vick <nate.vick@hint.io>
benjaminwood
force-pushed
the
send-version-information
branch
from
2d63e3f
to
0c56984
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This requires a change in the
selective-ruby-rspecgem, which is not yet released: selectiveci/selective-ruby-rspec#14. The specs here will fail until that is merged.Unfortunately we can't use the gemspec to ensure that a new version of the core gem which includes this change cannot be used with an older version of
selective-ruby-rspecthat does not have the dependent methods (such as#framework). This is because it'sselective-ruby-rspecthat has a dependency on core, not the other way around.Given that we're in the alpha testing stage with limited users, we may get away with just releasing both gems and expecting both gems to be updated when testers
bundle update selective-ruby-rspec. However, this won't be a great idea in the future when we have a more diverse install-base . The best we could do is implement changes like this in a compatible way. For example, do not add the new information if the framework wrapper gem (selective-ruby-rspec) doesn't have the methods we need.