Set a static run_attempt for Semaphore #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Semaphore, hitting the rerun button generates an entirely new build with a unique job id, workflow id, and pipeline id. As such, we don't have anything to group it by in order to tell if it is a rerun or not. Initially I figured I'd live the run_attempt blank since we generate one if it isn't set. But, then we have the problem were a straggler node can restart a build if it comes online after the build has finished. With this in mind, I think it's better to explicitly set a static run_attempt for Semaphore since each build is a one-shot. As an aside, perhaps we should consider ditching our auto-generated after all. Co-authored-by: Nate Vick <nate.vick@hint.io>
natevick
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Semaphore, hitting the rerun button generates an entirely new build with a unique job id, workflow id, and pipeline id. As such, we don't have anything to group it by in order to tell if it is a rerun or not.
Initially I figured I'd leave the run_attempt blank since we generate one if it isn't set. But, then we have the problem were a straggler node can restart a build if it comes online after the build has finished.
With this in mind, I think it's better to explicitly set a static run_attempt for Semaphore since each build is a one-shot.
As an aside, perhaps we should consider ditching our auto-generated after all.