Report at finish & bugfixes #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows runners to report some additional data at the end of the run. For example, we're using this to report the total amount of time spent in before/after :all hooks in RSpec. Co-authored-by: Nate Vick <nate.vick@hint.io>
This is a bug and in some scenarios can produce a bunch of useless data that slows things down. Co-authored-by: Nate Vick <nate.vick@hint.io>
Co-authored-by: Nate Vick <nate.vick@hint.io>
natevick
previously approved these changes
Feb 6, 2024
Ensure errors are handled so that it cannot prevent runner shutdown Co-authored-by: Nate Vick <nate.vick@hint.io>
natevick
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a new report_at_finish for debug purposes. We also discovered a few bugs in the process:
We've also extended the max number of retries to 10.