Use RSpec::Core::Runner#exit_code to determine exit status
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should be using this method because it takes non_example_failure into account. Additionally, it allows us to support use-cases where folks may be monkeying with the exit_code method. Co-authored-by: Nate Vick <nate.vick@hint.io>
natevick
force-pushed
the
use-rspec-exit-code-method
branch
from
e59d01f
to
53809af
Compare
natevick
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be using this method because it takes non_example_failure into account.
Additionally, it allows us to support use-cases where folks may be monkeying with the exit_code method.