Handle close message by exiting the transport #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, the client would end up receiving an empty message when the close message was received. This isn't good because the client expects JSON and an empty string would cause an error. This change adds a check for the close message and terminates the transport when it is received. This allows the client to retry if needed. This also has a nice side effect of resolving an additional error scenario where we weren't properly handling the "unwrap" of the message that has been factored out with this commit. This change also adds some debug output to help understand the types of messages that are being received. It will not be included in the release build. The code could definitely be cleaned up a bit, but that's a task for another day once we've gotten a bit further along. Co-authored-by: Nate Vick <nate.vick@hint.io>
natevick
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the client would end up receiving an empty message when the close message was received. This isn't good because the client expects JSON and an empty string would cause an error.
This change adds a check for the close message and terminates the transport when it is received. This allows the client to retry if needed.
This also has a nice side effect of resolving another error scenario where we weren't properly handling the "unwrap" of the message that has been factored out with this commit.
This change also adds some debug output to help understand the types of messages that are being received. It will not be included in the release build.
🙈 the code definitely needs some help now.