Skip to content

Commit

Permalink
Linking broken tests to geckodriver bug reports
Browse files Browse the repository at this point in the history
  • Loading branch information
barancev committed Apr 7, 2017
1 parent 0606379 commit b09d5df
Show file tree
Hide file tree
Showing 13 changed files with 29 additions and 49 deletions.
8 changes: 4 additions & 4 deletions java/client/test/org/openqa/selenium/ContentEditableTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public void switchToDefaultContent() {
@JavascriptEnabled
@Test
@Ignore(value = SAFARI, reason = "cannot type on contentEditable with synthetic events")
@Ignore(MARIONETTE)
@Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/594")
public void testTypingIntoAnIFrameWithContentEditableOrDesignModeSet() {
driver.get(pages.richTextPage);

Expand All @@ -67,7 +67,7 @@ public void testTypingIntoAnIFrameWithContentEditableOrDesignModeSet() {

@JavascriptEnabled
@Test
@Ignore(MARIONETTE)
@Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/594")
public void testNonPrintableCharactersShouldWorkWithContentEditableOrDesignModeSet() {
assumeFalse("FIXME: Fails in Firefox on Linux with synthesized events",
isFirefox(driver) &&
Expand Down Expand Up @@ -99,7 +99,7 @@ public void testShouldBeAbleToTypeIntoEmptyContentEditableElement() {
@Ignore(CHROME)
@Ignore(IE)
@Ignore(SAFARI)
@Ignore(MARIONETTE)
@Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/594")
public void testShouldBeAbleToTypeIntoContentEditableElementWithExistingValue() {
driver.get(pages.readOnlyPage);
WebElement editable = driver.findElement(By.id("content-editable"));
Expand Down Expand Up @@ -132,7 +132,7 @@ public void testShouldBeAbleToTypeIntoTinyMCE() {
@Ignore(CHROME)
@Ignore(IE)
@Ignore(value = SAFARI, reason = "cannot type on contentEditable with synthetic events, issue 3127")
@Ignore(MARIONETTE)
@Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/594")
public void testShouldAppendToTinyMCE() {
driver.get(appServer.whereIs("tinymce.html"));
driver.switchTo().frame("mce_0_ifr");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ public void testSubmittingFormFromFormInputTextElementShouldFireOnSubmitForThatF
@JavascriptEnabled
@Test
@Ignore(value = SAFARI, reason = "Does not yet support file uploads, issue 4220")
@Ignore(MARIONETTE)
@Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/594")
public void testUploadingFileShouldFireOnChangeEvent() throws IOException {
driver.get(pages.formPage);
WebElement uploadElement = driver.findElement(By.id("upload"));
Expand Down
4 changes: 2 additions & 2 deletions java/client/test/org/openqa/selenium/CssValueTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public class CssValueTest extends JUnit4TestBase {

@JavascriptEnabled
@Test
@Ignore(MARIONETTE)
@Ignore(value = MARIONETTE, issue = "3795")
public void testShouldPickUpStyleOfAnElement() {
driver.get(pages.javascriptPage);

Expand All @@ -49,7 +49,7 @@ public void testShouldPickUpStyleOfAnElement() {

@JavascriptEnabled
@Test
@Ignore(MARIONETTE)
@Ignore(value = MARIONETTE, issue = "3795")
public void testGetCssValueShouldReturnStandardizedColour() {
driver.get(pages.colorPage);

Expand Down
15 changes: 7 additions & 8 deletions java/client/test/org/openqa/selenium/ElementSelectingTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -45,28 +45,28 @@ public void testShouldBeAbleToSelectAnEnabledUnselectedRadioButton() {
}

@Test
@Ignore(MARIONETTE)
@Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/615")
public void testShouldNotBeAbleToSelectADisabledCheckbox() {
driver.get(pages.formPage);
assertCannotSelect(disabledUnselectedCheckbox());
}

@Test
@Ignore(MARIONETTE)
@Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/615")
public void testShouldNotBeAbleToSelectADisabledCheckboxDisabledWithRandomString() {
driver.get(pages.formPage);
assertCannotSelect(randomlyDisabledSelectedCheckbox());
}

@Test
@Ignore(MARIONETTE)
@Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/615")
public void testShouldNotBeAbleToSelectADisabledRadioButton() {
driver.get(pages.formPage);
assertCannotSelect(disabledUnselectedRadioButton());
}

@Test
@Ignore(MARIONETTE)
@Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/615")
public void testShouldNotBeAbleToSelectADisabledRadioButtonDisabledWithRandomString() {
driver.get(pages.formPage);
assertCannotSelect(randomlyDisabledUnselectedRadioButton());
Expand Down Expand Up @@ -112,7 +112,6 @@ public void testClickingOnASelectedRadioButtonShouldLeaveItSelected() {
}

@Test
@Ignore(MARIONETTE)
public void testShouldBeAbleToToggleEnabledMultiSelectOption() {
driver.get(pages.formPage);
assertCanToggle(selectedMultipleSelectOption());
Expand Down Expand Up @@ -147,21 +146,21 @@ public void testShouldBeAbleToSelectSelectableRadioButtonByClickingOnIt() {
}

@Test
@Ignore(MARIONETTE)
@Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/615")
public void testClickingDisabledSelectedCheckboxShouldBeNoop() {
driver.get(pages.formPage);
assertClickingPreservesCurrentlySelectedStatus(randomlyDisabledSelectedCheckbox());
}

@Test
@Ignore(MARIONETTE)
@Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/615")
public void testClickingDisabledUnselectedCheckboxShouldBeNoop() {
driver.get(pages.formPage);
assertClickingPreservesCurrentlySelectedStatus(disabledUnselectedCheckbox());
}

@Test
@Ignore(MARIONETTE)
@Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/615")
public void testClickingDisabledSelectedRadioButtonShouldBeNoop() {
driver.get(pages.formPage);
assertClickingPreservesCurrentlySelectedStatus(disabledSelectedRadioButton());
Expand Down
9 changes: 4 additions & 5 deletions java/client/test/org/openqa/selenium/FormHandlingTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ public void testSendKeysKeepsCapitalization() {
}

@Test
@Ignore(MARIONETTE)
@Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/594")
public void testShouldSubmitAFormUsingTheNewlineLiteral() {
driver.get(pages.formPage);
WebElement nestedForm = driver.findElement(By.id("nested_form"));
Expand Down Expand Up @@ -162,7 +162,7 @@ public void testShouldEnterDataIntoFormFields() {

@Test
@Ignore(value = SAFARI, reason = "issue 4220")
@Ignore(MARIONETTE)
@Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/594")
public void testShouldBeAbleToAlterTheContentsOfAFileUploadInputElement() throws IOException {
driver.get(pages.formPage);
WebElement uploadElement = driver.findElement(By.id("upload"));
Expand All @@ -179,7 +179,7 @@ public void testShouldBeAbleToAlterTheContentsOfAFileUploadInputElement() throws

@Test
@Ignore(value = SAFARI, reason = "issue 4220")
@Ignore(MARIONETTE)
@Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/594")
public void testShouldBeAbleToSendKeysToAFileUploadInputElementInAnXhtmlDocument()
throws IOException {
assumeFalse("IE before 9 doesn't handle pages served with an XHTML content type,"
Expand All @@ -201,7 +201,7 @@ public void testShouldBeAbleToSendKeysToAFileUploadInputElementInAnXhtmlDocument

@Test
@Ignore(value = SAFARI, reason = "issue 4220")
@Ignore(MARIONETTE)
@Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/594")
public void testShouldBeAbleToUploadTheSameFileTwice() throws IOException {
File file = File.createTempFile("test", "txt");
file.deleteOnExit();
Expand Down Expand Up @@ -271,7 +271,6 @@ public void testEmptyTextBoxesShouldReturnAnEmptyStringNotNull() {
@Test
@Ignore(PHANTOMJS)
@Ignore(SAFARI)
@Ignore(MARIONETTE)
public void handleFormWithJavascriptAction() {
String url = appServer.whereIs("form_handling_js_submit.html");
driver.get(url);
Expand Down
8 changes: 3 additions & 5 deletions java/client/test/org/openqa/selenium/FrameSwitchingTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ public void testShouldContinueToReferToTheSameFrameOnceItHasBeenSelected() {
}

@Test
@Ignore(MARIONETTE)
@Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/614")
public void testShouldFocusOnTheReplacementWhenAFrameFollowsALinkToA_TopTargetedPage()
throws Exception {
driver.get(pages.framesetPage);
Expand Down Expand Up @@ -484,16 +484,14 @@ public void testShouldBeAbleToSwitchToTheTopIfTheFrameIsDeletedFromUnderUsWithWe
@Ignore(CHROME)
@Ignore(HTMLUNIT)
@Ignore(IE)
@Ignore(MARIONETTE)
@Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/614")
@Ignore(PHANTOMJS)
@Ignore(SAFARI)
public void testShouldNotBeAbleToDoAnythingTheFrameIsDeletedFromUnderUs() {
driver.get(appServer.whereIs("frame_switching_tests/deletingFrame.html"));

driver.switchTo().frame("iframe1");

WebElement killIframe = driver.findElement(By.id("killIframe"));
killIframe.click();
driver.findElement(By.id("killIframe")).click();

Throwable t = catchThrowable(() -> driver.findElement(By.id("killIframe")));
assertThat(t, instanceOf(NoSuchFrameException.class));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ public void testDocumentShouldReflectLatestDom() throws Exception {

@JavascriptEnabled
@Test
@Ignore(MARIONETTE)
public void testShouldWaitForLoadsToCompleteAfterJavascriptCausesANewPageToLoad() {
driver.get(pages.formPage);

Expand All @@ -88,7 +87,6 @@ public void testShouldWaitForLoadsToCompleteAfterJavascriptCausesANewPageToLoad(

@JavascriptEnabled
@Test
@Ignore(MARIONETTE)
public void testShouldBeAbleToFindElementAfterJavascriptCausesANewPageToLoad() {
driver.get(pages.formPage);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
import org.openqa.selenium.testing.Ignore;
import org.openqa.selenium.testing.JUnit4TestBase;
import org.openqa.selenium.testing.JavascriptEnabled;
import org.openqa.selenium.testing.NotYetImplemented;
import org.openqa.selenium.testing.SwitchToTopAfterTest;
import org.openqa.selenium.testing.TestUtilities;

Expand Down Expand Up @@ -95,7 +96,7 @@ public void testShouldGetCoordinatesOfAnInvisibleElement() {

@Test
@Ignore(SAFARI)
@Ignore(MARIONETTE)
@NotYetImplemented(value = MARIONETTE, reason = "/window/rect")
public void testShouldScrollPageAndGetCoordinatesOfAnElementThatIsOutOfViewPort() {
assumeFalse(
"window().getSize() is not implemented for Chrome for Android. "
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,15 @@
import static org.hamcrest.Matchers.is;
import static org.junit.Assert.assertThat;
import static org.junit.Assert.assertTrue;
import static org.openqa.selenium.testing.Driver.MARIONETTE;

import org.junit.Test;
import org.openqa.selenium.testing.Ignore;
import org.openqa.selenium.testing.JUnit4TestBase;

import java.util.List;

public class SelectElementHandlingTest extends JUnit4TestBase {

@Test
@Ignore(MARIONETTE)
public void testShouldBePossibleToDeselectASingleOptionFromASelectWhichAllowsMultipleChoices() {
driver.get(pages.formPage);

Expand All @@ -50,7 +47,6 @@ public void testShouldBePossibleToDeselectASingleOptionFromASelectWhichAllowsMul
}

@Test
@Ignore(MARIONETTE)
public void testShouldBeAbleToChangeTheSelectedOptionInASelect() {
driver.get(pages.formPage);
WebElement selectBox = driver.findElement(By.xpath("//select[@name='selectomatic']"));
Expand All @@ -66,7 +62,6 @@ public void testShouldBeAbleToChangeTheSelectedOptionInASelect() {
}

@Test
@Ignore(MARIONETTE)
public void testShouldBeAbleToSelectMoreThanOneOptionFromASelectWhichAllowsMultipleChoices() {
driver.get(pages.formPage);

Expand All @@ -86,7 +81,6 @@ public void testShouldBeAbleToSelectMoreThanOneOptionFromASelectWhichAllowsMulti
}

@Test
@Ignore(MARIONETTE)
public void testShouldSelectFirstOptionByDefaultIfNoneIsSelected() {
driver.get(pages.formPage);
WebElement selectBox = driver.findElement(By.xpath("//select[@name='select-default']"));
Expand All @@ -102,7 +96,6 @@ public void testShouldSelectFirstOptionByDefaultIfNoneIsSelected() {
}

@Test
@Ignore(MARIONETTE)
public void testCanSelectElementsInOptGroups() {
driver.get(pages.selectPage);
WebElement element = driver.findElement(By.id("two-in-group"));
Expand All @@ -127,7 +120,6 @@ public void testCanGetValueFromOptionViaAttributeWhenAttributeIsEmptyString() {
}

@Test
@Ignore(MARIONETTE)
public void testCanSelectFromMultipleSelectWhereValueIsBelowVisibleRange() {
driver.get(pages.selectPage);
WebElement option = driver.findElements(By.cssSelector("#selectWithMultipleLongList option")).get(4);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@

import org.junit.Test;
import org.junit.runner.RunWith;
import org.openqa.selenium.support.ui.WebDriverWait;
import org.openqa.selenium.testing.Ignore;
import org.openqa.selenium.testing.SeleniumTestRunner;
import org.openqa.selenium.testing.drivers.WebDriverBuilder;
Expand Down Expand Up @@ -61,7 +60,7 @@ public void callingQuitAfterClosingTheLastWindowIsANoOp() {
@Ignore(value = FIREFOX, issue = "3792")
@Ignore(value = PHANTOMJS, reason = "throws NoSuchWindowException")
@Ignore(value = SAFARI, reason = "throws NullPointerException")
@Ignore(MARIONETTE)
@Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/613")
public void callingAnyOperationAfterClosingTheLastWindowShouldThrowAnException() {
WebDriver driver = new WebDriverBuilder().get();

Expand Down
5 changes: 2 additions & 3 deletions java/client/test/org/openqa/selenium/UploadTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import static org.openqa.selenium.WaitingConditions.elementTextToEqual;
import static org.openqa.selenium.support.ui.ExpectedConditions.not;
import static org.openqa.selenium.support.ui.ExpectedConditions.visibilityOf;
import static org.openqa.selenium.testing.Driver.HTMLUNIT;
import static org.openqa.selenium.testing.Driver.IE;
import static org.openqa.selenium.testing.Driver.MARIONETTE;
import static org.openqa.selenium.testing.Driver.PHANTOMJS;
Expand Down Expand Up @@ -62,7 +61,7 @@ public void setUp() throws Exception {
@JavascriptEnabled
@SwitchToTopAfterTest
@Test
@Ignore(MARIONETTE)
@Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/594")
public void testFileUploading() throws Exception {
assumeFalse(
"This test as written assumes a file on local disk is accessible to the browser. "
Expand All @@ -86,7 +85,7 @@ public void testFileUploading() throws Exception {
@Ignore(IE)
@Ignore(PHANTOMJS)
@Ignore(SAFARI)
@Ignore(MARIONETTE)
@Ignore(value = MARIONETTE, issue = "https://github.com/mozilla/geckodriver/issues/594")
public void testCleanFileInput() throws Exception {
driver.get(pages.uploadPage);
WebElement element = driver.findElement(By.id("upload"));
Expand Down
2 changes: 0 additions & 2 deletions java/client/test/org/openqa/selenium/VisibilityTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,6 @@ public void testShouldShowElementNotVisibleWhenParentElementHasHiddenAttribute()
@JavascriptEnabled // element.getCssValue() requires Javascript in HtmlUnit
@Test
@Ignore(IE)
@Ignore(MARIONETTE)
public void testShouldBeAbleToClickOnElementsWithOpacityZero() {
driver.get(pages.clickJacker);

Expand All @@ -297,7 +296,6 @@ public void testShouldBeAbleToClickOnElementsWithOpacityZero() {
}

@Test
@Ignore(MARIONETTE)
public void testShouldBeAbleToSelectOptionsFromAnInvisibleSelect() {
driver.get(pages.formPage);

Expand Down
Loading

0 comments on commit b09d5df

Please sign in to comment.