-
-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing sRGB using home brew build on OS X, no need for workaround #103
Comments
I just did brew install emacs --srgb --cocoa --use-git-head and it seems to work without disabling the srgb workaround. Any reason why? |
|
@localredhead If I were to hazard a guess, it seems to work because the workaround colors are very close to Solarized (else it wouldn't be a very good workaround :), but disabling the workaround gets you Solarized colors on the dot. @adamv |
You must be using some custom emacs formula then, because the stock emacs formula definitely doesn't respond to |
I'm not sure why it's not working for you, it's definitely not a custom formula. It's just version to install (instead of HEAD). |
Passing an arbitrary version doesn't do anything, only |
All right, updated. Regardless, don't use |
The stable formula now supports |
We now check |
👍 |
😸 Awesomesauce. Stable formula built with |
@toolbear I noticed that too. Let me know how the HEAD build works out for you; it was really unstable for me (window resizing wasn't even working). |
Must have just been yesterday's build. Rebuilt today, working perfectly. |
@toolbear Likewise! It's beautiful. Thanks @sellout. |
On OS X, Emacs is best installed through home brew, using the command
brew install emacs --srgb --cocoa --use-git-head
This compiles a Cocoa build of Emacs with fixed sRGB color support, and additionally builds off the git tag emacs-24.3.
With sRGB enabled, disabling the workaround is required,
(setq solarized-broken-srgb 'nil)
. Currently this package defaults to enabling the work-around on all Darwin systems, and does not check whether it was built with sRGB support or not (I'll be looking into how this could be remedied).Doing this, I checked the colors I was getting versus the Schoonover's screenshots, and they're just about perfect.
Edit: don't pass
--HEAD
(or--emacs-24.3
, contrary to some random blog post I read long ago) or you'll get the latest (like master) build of emacs, which breaks from time to time. Leave it be, use 24.3.The text was updated successfully, but these errors were encountered: