Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add web-mode customizations #185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add web-mode customizations #185

wants to merge 1 commit into from

Conversation

geraldus
Copy link
Contributor

Override following faces:

  • web-mode-current-column-highlight-face
  • web-mode-current-element-highlight-face

Before:
2016-02-20 23 40 49
2016-02-20 23 41 18

After:
2016-02-20 23 41 49
2016-02-20 23 42 13

@geraldus
Copy link
Contributor Author

Wait, don't merge this. I've found I could add more faces! :D

@geraldus
Copy link
Contributor Author

Ok, now it looks better (:
2016-02-21 1 01 22
2016-02-21 1 01 45

Javascript preview:
2016-02-21 1 56 48
2016-02-21 1 57 42

@geraldus
Add few web-mode customizations
0a83940 
Customize current collumn and tag highlight faces
Customize html faces
Customize few javascript faces
@geraldus
Copy link
Contributor Author

@sellout oh, I guess it is better to inherit properties from Javascript and HTML faces, let me check how HTML and Javascript in native modes and how them appear in Vim. I'll ping you a bit later.

@geraldus
Copy link
Contributor Author

Hmm… @sellout default HTML and Javascript highlighting do not shine both in Emacs and Vim too. First of all coloring is different in Emacs and Vim. Second, Vim colouring is quite odd and very different to what I see on screenshot :D I have no idea what is the best way to go from here. I could provide screenshots for both Emacs and Vim colors.

Also I have few off-topic questions, is it OK to ask them in separate issues?

@geraldus geraldus changed the title Add web-mode hightligh customizations Add web-mode customizations Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@geraldus