Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor solarized-definitions.el for customization #191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Oct 20, 2016

  1. Refactor solarized-definitions.el for customization

    * add macro solarized-with-color-variables
    * pull solarized-apply-definitions out of create-solarized-theme
    
    This makes it easier to customize and test proposed changes to
    solarized-color-definitions. solarized-with-color-variables allows
    definition of faces within the same context that is used for
    solarized-color-definitions. Hence, the changes you test yourself can
    be directly copied into the official code-base for a PR. They are also
    easy to maintain in your own Emacs init scripts before merge or if
    tweaking the official settings. The approach is copied from @bbatsov's
    themes.
    
    For example, setting up additions/customizations goes like this:
    
    (defvar my/solarized-extra-definitions
      (solarized-with-color-variables
        `(;; cperl
          (cperl-array-face (,@fg-blue))
          (cperl-hash-face (,@fg-blue))
          (cperl-nonoverridable-face (,@fg-magenta)))))
    (solarized-apply-definitions my/solarized-extra-definitions 'solarized)
    sambrightman committed Oct 20, 2016
    Configuration menu
    Copy the full SHA
    a8a1fb0 View commit details
    Browse the repository at this point in the history