Fix org-mode todo and done faces

[huyz]

I've written a detailed explanation of how "bold" is intended to work in terminals, near the bottom of https://github.com/huyz/dircolors-solarized
Bold must not be disabled, otherwise we lose access to Solarized colors such as orange and purple; we just need to pick different colors, in this case simple "green". Neither selecting "bold green" or disabling bold in terminals is Solarized-compatible.

Also, reverse-video does not work well with sparse trees. So bounding boxes are better.

[sellout]

Sorry this took eight years. I appreciate the contribution. But these changes don’t fit the original Vim theme.

[sellout]

These have changed a bit since then, they now match what the Vim theme uses for pandocLinkText.

[sellout]

These faces are probably good, but they’re not in the vein of the original Vim Solarized theme.

I’m in the process of applying something like #191 to make it easier to extend Solarized, so that you could add these faces locally by doing something like

(deftheme huyz-solarized "Extensions to the Solarized theme.")
(apply #'custom-theme-set-faces 'huyz-solarized
       (solarized-with-color-variables
        `((org-todo-kwd-face ((t (,@fg-red ,@bg-base03 :box (:line-width 1 :color ,red :style released-button)))))
           (org-done-kwd-face ((t (,@fg-green ,@bg-base03 :box (:line-width 1 :color ,green :style released-button)))))
           (org-someday-kwd-face ((t (,@fg-magenta ,@bg-base03 :box (:line-width 1 :color ,magenta :style released-button)))))
           (org-appt-kwd-face ((t (,@fg-orange ,@bg-base03 :box (:line-width 1 :color ,orange :style released-button)))))
           (org-waiting-kwd-face ((t (,@fg-orange ,@bg-base03 :box (:line-width 1 :color ,orange :style released-button)))))
           (org-started-kwd-face ((t (,@fg-yellow ,@bg-base03 :box (:line-width 1 :color ,yellow :style released-button)))))
           (org-next-kwd-face ((t (,@fg-base03 ,@bg-yellow))))
           (org-cancelled-kwd-face ((t (,@fg-cyan ,@bg-base03 :box (:line-width 1 :color ,cyan :style released-button)))))
           (org-delegated-kwd-face ((t (,@fg-cyan ,@bg-base03 :box (:line-width 1 :color ,cyan :style released-button)))))
           (org-deferred-kwd-face ((t (,@fg-cyan ,@bg-base03 :box (:line-width 1 :color ,cyan :style released-button)))))))

(customize-set-variables
 '(custom-enabled-themes (huyz-solarized solarized))

I actually do something similar locally, because I don’t always agree with Solarized, and I plan to add some variants to the repo as well, but I want this theme to match the original as much as possible.

[sellout]

These faces (at least the first 6) are selected to match the original theme, but again, can be overridden locally once I have #191 merged.

[sellout]

I’ve made a note to review how the theme uses :bold. I think it should probably be configurable for the user to set it to match how they configure bold in their terminal (i.e., toggle between using it for bold font or for bright colors) along with some commentary like in your dircolors repo about why it should generally be kept for bright colors.

Thanks!