Add the GHC used by Hackage to the build matrix #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should try to ensure that our build will behave properly on Hackage (which it currently doesn’t seem to do. This also simplifies the `tested-with` field.
|
So, if this isn’t failing, it’s not worth merging, because it’s not modeling Hackage closely enough. Alternatively, if we upload the docs to Hackage ourselves (which is probably better than realizing they’re broken after uploading to Hackage), then Hackage probably doesn’t bother to build the package at all, and we don’t need this PR at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should try to ensure that our build will behave properly on Hackage (which it currently doesn’t seem to do).
This also simplifies the
tested-withfield.