test(structure): consolidated all verification under the test script
#719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while also enabling isolated execution. similar to semantic-release/semantic-release#2964 for semantic-release/.github#19
gr2m
approved these changes
Oct 23, 2023
| @@ -8,7 +8,13 @@ name: Test | |||
| types: | |||
| - opened | |||
| - synchronize | |||
|
|
|||
| env: | |||
| FORCE_COLOR: 1 | |||
| with: | ||
| node-version: "lts/*" | ||
| node-version-file: .nvmrc |
There was a problem hiding this comment.
NICEE! I didn't know that was possible!
There was a problem hiding this comment.
i try to make the nvmrc the source of truth for as much as possible. even more important for apps where supporting a matrix is less of an issue.
big side benefit of having a job in the workflow that references that file is that renovate updates this file, so it can fail before merge if anything about the project doesnt support that version
| @@ -17,7 +18,8 @@ | |||
| }, | |||
| "contributors": [ | |||
| "Stephan Bönnemann <stephan@boennemann.me> (http://boennemann.me)", | |||
| "Gregor Martynus (https://twitter.com/gr2m)" | |||
| "Gregor Martynus (https://twitter.com/gr2m)", | |||
| "Matt Travi <npm@travi.org> (https://matt.travi.org/)" | |||
|
🎉 This PR is included in version 9.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while also enabling isolated execution. similar to semantic-release/semantic-release#2964
for semantic-release/.github#19