-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: compare only <owner>/<repo> when checking for rename #886
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff @jedwards1211,
Do rake a look at the bit of nits and kindly resolve the conflict for now... We are looking to add some tests too... We'll look at how to go about that after this.
@babblebey okay I made those changes and included the current There are unrelated formatting changes in here now that I ran |
Okay I opened this issue: #890 |
Run |
sorry for the noise, |
@babblebey okay I added tests for |
Nice testing setup y'all! I like the thoroughness of the GitHub mocking, and also the fact that you aren't using Jest lol |
@babblebey anything else y'all need on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jedwards1211 😁,
I gave this a whirl 😉, changes looks great 👍.... and thank you for sticking to this. I have also gone on and written a description for the PR.
In order to fulfil the test coverage requirement mentioned in the reverted PR #887. Please take a look at the review comment.
This is great stuff right here @jedwards1211. I commend you for sticking to this yea. I have given another whirl and added a video demo of my testing to the PR Description (reviewers like that stuff 😉). |
nice, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
🎉 This issue has been resolved in version 10.1.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR re-attempts the implementation made in #878 and reverted in #887, by staging a check in the plugin
verifyConditions
lifecycle using theowner/repo
as opposed to the initial implementation where thecontext.options.repositoryUrl
is compared against the fetched repoclone_url
.Related to #885
Screencast
Error Demo
screencast-bpconcjcammlapcogcnnelfmaeghhagj-2024.1.mp4
Success Demo
screencast-bpconcjcammlapcogcnnelfmaeghhagj-2024.2.mp4