Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency aggregate-error to v4 #469

Merged
merged 2 commits into from
Jan 30, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 17, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
aggregate-error ^3.0.0 -> ^4.0.0 age adoption passing confidence

Release Notes

sindresorhus/aggregate-error

v4.0.1

Compare Source

v4.0.0

Compare Source

Breaking
  • Require Node.js 12 4f8546b
  • This package is now pure ESM. Please read this.
  • Move attached errors to an .errors property 02342f9

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot changed the title Update dependency aggregate-error to v4 fix(deps): update dependency aggregate-error to v4 Dec 17, 2022
@renovate renovate bot force-pushed the renovate/aggregate-error-4.x branch 5 times, most recently from d8a87a8 to ec6f455 Compare January 9, 2023 05:56
@renovate renovate bot force-pushed the renovate/aggregate-error-4.x branch 4 times, most recently from 9a88106 to bc3404b Compare January 13, 2023 23:01
@renovate renovate bot force-pushed the renovate/aggregate-error-4.x branch 8 times, most recently from 02cd638 to 4643712 Compare January 27, 2023 10:05
@fgreinacher
Copy link
Contributor

@gr2m @travi WDYT we take this as a chance to get rid of the dependency and switch to native AggregateError?

@travi
Copy link
Member

travi commented Jan 27, 2023

good question.

before i address that directly, i'll start by saying that i meant to highlight this package as part of the ESM transition because of the fact that upgrading this one does impact the public interface of this package in a way. i would have been best to include in the collection of breaking changes, so i apologize that didn't catch this then. we did upgrade in core and have upgraded in the beta of the npm plugin. regardless of how we proceed, i think it is valid to think of the change as a fix since it was "intended" to be part of that release.

to answer your question more directly, i can admit that i havent looked deep enough yet to understand what the impact would be. i knew v4 better aligned with the standard, but with all the other changes happening, that was as far as i went in order to try to focus on getting the new stuff out there. since we've already gone the route of upgrading in core, does that limit our options here at all? is alignment with the spec complete at this point, or are there still differences at this point that we need to consider?

@renovate renovate bot force-pushed the renovate/aggregate-error-4.x branch from 4643712 to 9d48f86 Compare January 30, 2023 05:20
@renovate renovate bot force-pushed the renovate/aggregate-error-4.x branch from 9d48f86 to a2d7757 Compare January 30, 2023 09:35
@fgreinacher
Copy link
Contributor

we did upgrade in core and have upgraded in the beta of the npm plugin

OK, then I'll do the upgrade here too to get the fix out soonish. I think with the current status we will lose some error details when using latest core and gitlab plugins.

is alignment with the spec complete at this point

Looks they are not 100% compatible (although maybe good enough for our use cases), see e.g. sindresorhus/aggregate-error#4 (comment). Maybe let's just leave it as-is to keep changes low

@renovate
Copy link
Contributor Author

renovate bot commented Jan 30, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@fgreinacher
Copy link
Contributor

@travi Thanks for your feedback, could you have a look at e40ced2?

@gr2m gr2m merged commit 96bb3e9 into master Jan 30, 2023
@gr2m gr2m deleted the renovate/aggregate-error-4.x branch January 30, 2023 23:37
@github-actions
Copy link

🎉 This PR is included in version 10.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants