-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency aggregate-error to v4 #469
Conversation
d8a87a8
to
ec6f455
Compare
9a88106
to
bc3404b
Compare
02cd638
to
4643712
Compare
@gr2m @travi WDYT we take this as a chance to get rid of the dependency and switch to native |
good question. before i address that directly, i'll start by saying that i meant to highlight this package as part of the ESM transition because of the fact that upgrading this one does impact the public interface of this package in a way. i would have been best to include in the collection of breaking changes, so i apologize that didn't catch this then. we did upgrade in core and have upgraded in the beta of the npm plugin. regardless of how we proceed, i think it is valid to think of the change as a fix since it was "intended" to be part of that release. to answer your question more directly, i can admit that i havent looked deep enough yet to understand what the impact would be. i knew v4 better aligned with the standard, but with all the other changes happening, that was as far as i went in order to try to focus on getting the new stuff out there. since we've already gone the route of upgrading in core, does that limit our options here at all? is alignment with the spec complete at this point, or are there still differences at this point that we need to consider? |
4643712
to
9d48f86
Compare
9d48f86
to
a2d7757
Compare
OK, then I'll do the upgrade here too to get the fix out soonish. I think with the current status we will lose some error details when using latest core and gitlab plugins.
Looks they are not 100% compatible (although maybe good enough for our use cases), see e.g. sindresorhus/aggregate-error#4 (comment). Maybe let's just leave it as-is to keep changes low |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. ⚠ Warning: custom changes will be lost. |
96ee161
to
e40ced2
Compare
🎉 This PR is included in version 10.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR contains the following updates:
^3.0.0
->^4.0.0
Release Notes
sindresorhus/aggregate-error
v4.0.1
Compare Source
74a869b
v4.0.0
Compare Source
Breaking
4f8546b
.errors
property02342f9
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.