-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not update workspaces when applying new version #482
fix: do not update workspaces when applying new version #482
Conversation
can you provide more context around the situation where you are seeing this? i've never seen this error in projects that do not have workspaces defined. note that semantic-release core does not officially support monorepos. are you using something in addition to semantic-release to enable functionality within a monorepo? |
Hello @travi, in my case we use yarn workspaces. Adding the option |
are you managing multiple packages in the same repository through the use of yarn workspaces? assuming so, what else are you using to make this work with semantic-release? semantic-release does not support that type of repository structure by itself |
Yes we manage multiple packages and we use |
Hello @travi, |
the use case is still being considered, but i do have concerns. as mentioned above, semantic-release does not officially support monorepos, so this is technically outside of what we would normally consider. we do, however, unofficially want to enable other tools to build on top of semantic-release to enable specific support, but that still has to be balanced with additional maintenance cost the change would add to our workload long term. it feels out of place to have semantic-release manage this flag that is specific to monorepos when the tool primarily targets non-monorepos. is there a reason why you could not configure this in the |
Hello @travi, sorry for the long delay from my side. |
@travi Setting it in the npmrc fix well the issue 👍🏾 Thanks for the suggestion |
@KillianHmyd can you please share the content of your .npmrc, did you just wrote |
@mario-jerkovic I was able to publish a monorepo with semantic-release using this
Make sure the root package doesn't have |
In npm@8 the command
npm version
added a new command workspaces-update which istrue
by default.This option cause the following error when we install workspaces using non-released version (in this case the version
0.0.0-semantic-release
) :