Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add predicate offers - fixes #528 #1102

Merged
merged 10 commits into from
Jun 24, 2024
Merged

Add predicate offers - fixes #528 #1102

merged 10 commits into from
Jun 24, 2024

Conversation

stevenchalem
Copy link
Contributor

@stevenchalem stevenchalem commented Jun 11, 2024

Closes #528.

Added predicate gist:isOfferOf, and changed the formal definition of gist:Offer to refer to the new predicate instead of gist:hasDirectPart

@stevenchalem stevenchalem self-assigned this Jun 11, 2024
Copy link
Contributor

@Jamie-SA Jamie-SA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prefLabel needs to be fixed, and a possible suggestion for the release notes.

docs/release_notes/issue528-add-isOfferOf.md Outdated Show resolved Hide resolved
ontologies/gistCore.ttl Outdated Show resolved Hide resolved
Copy link
Contributor

@uscholdm uscholdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change prefLabel per Jamie's suggestion.
Update release notes per my suggestion

docs/release_notes/issue528-add-isOfferOf.md Outdated Show resolved Hide resolved
docs/release_notes/issue528-add-isOfferOf.md Outdated Show resolved Hide resolved
docs/release_notes/issue528-add-isOfferOf.md Outdated Show resolved Hide resolved
ontologies/gistCore.ttl Outdated Show resolved Hide resolved
@rjyounes
Copy link
Collaborator

rjyounes commented Jun 13, 2024

We've agreed to change from isOfferOf to offers. Maybe add scopeNote/example about the different uses (with Offer vs Organization/Person etc).

Need to generalize the definition.

@rjyounes
Copy link
Collaborator

rjyounes commented Jun 13, 2024

DECISION:

skos:definition "Relates something to a thing it makes available for acceptance or rejection." ;
skos:example "An instance of gist:Offer offers a specific product at a particular price; a company offers an employee benefit; Honda offers vehicles for sale.";

@stevenchalem stevenchalem changed the title Add predicate isOfferOf - fixes #528 Add predicate offers - fixes #528 Jun 13, 2024
@uscholdm
Copy link
Contributor

@stevenchalem

skos:definition "Relates something to a thing it makes available for acceptance or rejection."

I suggest:

  • skos:definition "Relates something to a thing that is being made available for acceptance or rejection."

Copy link
Contributor

@uscholdm uscholdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of rewording suggestions.

ontologies/gistCore.ttl Outdated Show resolved Hide resolved
ontologies/gistCore.ttl Outdated Show resolved Hide resolved
@rjyounes
Copy link
Collaborator

@stevenchalem Sorry about the back and forth. Michael is willing to go ahead with offers and I trust his judgment on this. So let's go ahead and finalize this PR. Thanks.

@rjyounes rjyounes dismissed Jamie-SA’s stale review June 24, 2024 13:47

All requests have been addressed.

@rjyounes rjyounes merged commit 01fd463 into develop Jun 24, 2024
1 check passed
@rjyounes rjyounes deleted the isOfferOf branch June 24, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Define predicate gist:offers to use with Offer in place of hasDirectPart
5 participants