-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue 782 simplify units. Fixes #782. #784
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bel) - Define StandardUnit to be equivalent to a UnitOfMeasure that - has conversion=1 - has itself as a standard unit - has a scopeNote indicating that this captures the idea of dimension - UnitOfMeasure - make equivalent to a Magnitude that - has numericValue =1 (it's not called 'unit' for nothing) - has itself at its unit of measure - has conversion=1 - has a standard unit - remove unit of measure from disjoints where incorrect or redundant
- Remove: ProductUnit, CoherentProductUnit, ProductMagnitude - REmove: RatioUnit, CoherentRatioUnit, RatioMagnitude - Aspect - Make Aspect a not a subclass of Category. Aspects such as like length, or inner diameter or cycle time do not exist for the purpose of categorizing things. - Make Aspect a subclass of SchemaMetaData. An aspect is a representation of a property connecting two things. It has roughly the same meaning as an OWL property. - Add scopeNote to hasPrecision to say the precision of a Magnitude must have the same StandardUnit as the Magnitude.
…itOfMeasure - Removed uses and mentions of product and ratio unit and magnitude classes and update definitions and annotations accordingly. - Percentage was redefined because it had been a subclass of RatioMagnitude which was defined in terms of RationUnit. The old definitions are inserted as blank nodes to retain same formal meaning. - Fixed an erroneous definition of Magnitude and added examples
…ume units respectively. FIxed bug - was using wrong conversion predicate.
…an of the more specifit class, (e..g DurationUnit)
… the split out units magnitudes branch.
rjyounes
changed the title
Feature/issue 782 simplify units
Feature/issue 782 simplify units. Fixes #782.
Feb 9, 2023
@uscholdm Closing this PR. Keeping the branch to retain the modifications, but it will be addressed in the general units and magnitudes overhaul. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a bunch of changes to simplify and clean up things as described in #782 . Main changes are:
This is ready for a preliminary review to get early feedback and catch any mistakes.
STILL TO DO:
Details
StandardUnit
UnitOfMeasure
Removed product and ratio units and magnitudes
Aspect
Magnitude