Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(group): after a sequence of updates a proof is invalid #910

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

Lauman
Copy link
Contributor

@Lauman Lauman commented Dec 4, 2024

Description

When a member is removed from the group (update a leaf with 0n) and then another member is updated, the root that is saved is not correct, so the proof that is generated is not valid.
This bug is fixed by updating the lean-imt library, which was recently updated.
I detected this when I was testing the script create-mock-groups.

Other information

The fix
privacy-scaling-explorations/zk-kit#355

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn format and yarn lint without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

packages/contracts/test/Semaphore.ts Outdated Show resolved Hide resolved
packages/contracts/test/Semaphore.ts Outdated Show resolved Hide resolved
@cedoor cedoor merged commit 5b92c0a into semaphore-protocol:main Dec 9, 2024
5 checks passed
Copy link

gitpoap-bot bot commented Dec 9, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Semaphore Contributor:

GitPOAP: 2024 Semaphore Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants