Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): bump ethers to v6.13.4 #921

Merged
merged 1 commit into from
Dec 12, 2024
Merged

fix(core): bump ethers to v6.13.4 #921

merged 1 commit into from
Dec 12, 2024

Conversation

jacque006
Copy link
Contributor

Description

  • Update ethers version to resolve ws security issue (CVE-2024-37890).
  • Move contract address check outside of branch statement so Typescript can see.
  • Add build instructions to setup to resolve 'Cannot find module '@semaphore-protocol/...' when running tests for the first time.

Related Issue

Resolves #920

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn format and yarn lint without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@jacque006
fix(core): bump ethers to v6.13.4
dcd9182 
Update ethers version to resolve ws security issue (CVE-2024-37890).
Move contract address check outside of branch statement so Typescript can see.
Add build instructions to setup to resolve 'Cannot find module '@semaphore-protocol/...' when
running tests for the first time.

re semaphore-protocol#920
@jacque006 jacque006 requested a review from a team as a code owner December 11, 2024 23:20
cedoor
cedoor approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@cedoor cedoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jacque006 🙏🏽

@cedoor cedoor merged commit 13a9480 into semaphore-protocol:main Dec 12, 2024
5 checks passed
@gitpoap-bot gitpoap-bot
Copy link

gitpoap-bot bot commented Dec 12, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Semaphore Contributor:

GitPOAP: 2024 Semaphore Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@jacque006 jacque006 deleted the fix/ethers-ws-security-alert branch December 12, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedoor cedoor cedoor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Security alert on install from ethers, ws
2 participants
@jacque006 @cedoor