Remove redundant on-tags argument from list-diff

semaphoreci · Jun 8, 2022 · ca01361 · ca01361
1 parent 997668e
commit ca01361
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/pkg/cli/list_diff.go b/pkg/cli/list_diff.go
@@ -19,9 +19,8 @@ var listDiffCmd = &cobra.Command{
 		defaultBranch := fetchOptionalStringFlag(cmd, "default-branch")
 		defaultRange := fetchOptionalStringFlag(cmd, "default-range")
 		branchRange := fetchOptionalStringFlag(cmd, "branch-range")
-		onTags := fetchOptionalBoolFlag(cmd, "on-tags")
 
-		gitDiffSet := git.NewDiffSet(defaultBranch, defaultRange, branchRange, onTags)
+		gitDiffSet := git.NewDiffSet(defaultBranch, defaultRange, branchRange, true)
 
 		if gitDiffSet.IsEvaluationNeeded() {
 			println("Listing diffs for tags is not supported.")
@@ -60,7 +59,6 @@ func init() {
 	listDiffCmd.Flags().String("default-branch", "", "default branch of repository")
 	listDiffCmd.Flags().String("default-range", "", "default range for evaluation")
 	listDiffCmd.Flags().String("branch-range", "", "branch range for evaluation")
-	listDiffCmd.Flags().Bool("on-tags", true, "if commands is running on tags")
 
 	rootCmd.AddCommand(listDiffCmd)
 }
diff --git a/test/e2e/list_diff_on_tags.rb b/test/e2e/list_diff_on_tags.rb
@@ -65,7 +65,7 @@
 
 assert_eq($?.exitstatus, 0)
 assert_eq([], output)
-assert_eq(["Running on a tag, skipping evaluation."], error)
+assert_eq(["Listing diffs for tags is not supported."], error)
 
 repo.run(%{
   export SEMAPHORE_GIT_REF_TYPE=branch