Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for influx line protocol #4

Merged
merged 14 commits into from
Nov 27, 2019

Conversation

megastef
Copy link
Contributor

No description provided.

@megastef megastef requested a review from adnanrahic November 20, 2019 19:20
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
lib/agent.js Show resolved Hide resolved
@adnanrahic adnanrahic self-requested a review November 26, 2019 09:33
Copy link

@adnanrahic adnanrahic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Otis' comments. After it is fixed, let get it merged. I've also added a comment about wrapping some parts of the code in functions for better readability.

@megastef megastef requested a review from adnanrahic November 26, 2019 13:52
@megastef megastef merged commit 28d41af into master Nov 27, 2019
@megastef megastef deleted the sc-4541-support-influx-line-protocol branch January 22, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants