-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade usage of NodeJS from 12 to 16 #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change version in package.json? And while you're there upgrade the dependencies as well?
Done. The amount of file changes comes from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The is no .gitignore. I suppose it was never built outside GitHub.
9341d3d
to
5035bcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You better squash the commits. Now the git history contains all the ignored files.
Which commits? It will contain the ignored files anyway this once. |
Uh, can we make sure that we are doing the right thing before we are throwing away half the repository? |
https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action#commit-tag-and-push-your-action-to-github explicitely mentions that you check in your node modules, so don't just go around throwing it away without thinking about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
5035bcd
to
7e82026
Compare
`yarn upgrade` and explcitly bump versions up in package.json
7e82026
to
82e14c7
Compare
My mistake. I thought the original (master) version did not contain the node-modules. I now understand this repository is a runnable system and not a source to build artifacts from. |
Can this be merged? |
Yes. |
Merged, but it will need some tagging (add v1.1.0, add v1.0.0, move v1 tag) |
VERY IN SYNC WE ARE TODAY JOHAN |
I will continue. |
Done. |
Ref. https://github.com/semestry/tasks/issues/204#issuecomment-1327291496
Proposed changes
Updates this action to the recommended NodeJS version.
Testing
N/A
Documentation
N/A