Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade usage of NodeJS from 12 to 16 #2

Merged
merged 3 commits into from
Nov 28, 2022
Merged

Conversation

troley
Copy link
Contributor

@troley troley commented Nov 25, 2022

Ref. https://github.com/semestry/tasks/issues/204#issuecomment-1327291496

Proposed changes

Updates this action to the recommended NodeJS version.

Testing

N/A

Documentation

N/A

Copy link
Contributor

@johanwortel johanwortel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change version in package.json? And while you're there upgrade the dependencies as well?

@troley
Copy link
Contributor Author

troley commented Nov 25, 2022

Done. The amount of file changes comes from yarn upgrade. Then I also bumped the dependency versions up in the package.json.

@troley troley requested a review from johanwortel November 25, 2022 14:43
Copy link
Contributor

@johanwortel johanwortel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The is no .gitignore. I suppose it was never built outside GitHub.

@troley troley force-pushed the feature/update-nodejs branch 2 times, most recently from 9341d3d to 5035bcd Compare November 28, 2022 07:19
@troley troley requested a review from johanwortel November 28, 2022 07:21
Copy link
Contributor

@johanwortel johanwortel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You better squash the commits. Now the git history contains all the ignored files.

@troley
Copy link
Contributor Author

troley commented Nov 28, 2022

You better squash the commits. Now the git history contains all the ignored files.

Which commits? It will contain the ignored files anyway this once.

@MikeN123
Copy link

Uh, can we make sure that we are doing the right thing before we are throwing away half the repository?

@MikeN123
Copy link

https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action#commit-tag-and-push-your-action-to-github explicitely mentions that you check in your node modules, so don't just go around throwing it away without thinking about it.

Copy link

@MikeN123 MikeN123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@troley troley force-pushed the feature/update-nodejs branch from 5035bcd to 7e82026 Compare November 28, 2022 08:51
Rene Uhliar added 2 commits November 28, 2022 09:54
`yarn upgrade` and explcitly bump versions up in package.json
@troley troley force-pushed the feature/update-nodejs branch from 7e82026 to 82e14c7 Compare November 28, 2022 08:54
@johanwortel
Copy link
Contributor

Uh, can we make sure that we are doing the right thing before we are throwing away half the repository?

My mistake. I thought the original (master) version did not contain the node-modules. I now understand this repository is a runnable system and not a source to build artifacts from.

@Mario2804
Copy link
Contributor

Mario2804 commented Nov 28, 2022

Can this be merged?

@MikeN123 MikeN123 merged commit 1020cb2 into master Nov 28, 2022
@MikeN123 MikeN123 deleted the feature/update-nodejs branch November 28, 2022 14:19
@johanwortel
Copy link
Contributor

Can this be merged?

Yes.
I have already added tag v1.0.0 to tag the old (v1) version.
After the merge the tag v1 has to be put on the new master HEAD. From then on this will be the version used in GitHub workflows.
We can also add a v1.1.0 tag.

@MikeN123
Copy link

Merged, but it will need some tagging (add v1.1.0, add v1.0.0, move v1 tag)

@MikeN123
Copy link

VERY IN SYNC WE ARE TODAY JOHAN

@johanwortel
Copy link
Contributor

I will continue.

@johanwortel
Copy link
Contributor

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants