Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Semestry branch naming convention to checks #3

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

andrewmitchellsemestry
Copy link
Contributor

Ref. No reference number

Proposed changes

When creating PRs in TermTime, we keep getting messages to say that our branches don't match the naming conventions. To combat this, I propose adding our branch naming conventions to this repo so that we no longer have to ignore these warning and they will only show when needed.

Testing

None

Documentation

Updated the README

@MikeN123
Copy link

@johanwortel I believe https://semestry.atlassian.net/wiki/spaces/TT/pages/2737242113/Git+workflow#Branching-model discusses the TermTime branching model.

Copy link
Contributor

@johanwortel johanwortel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing is done with development-test and development-staging. Is that correct? Surely development is done on future versions?

action.yml Show resolved Hide resolved
action.yml Show resolved Hide resolved
index.js Show resolved Hide resolved
@andrewmitchellsemestry
Copy link
Contributor Author

@johanwortel I have updated the PR so that the regex is more concise and will consider the development-test and development-staging branches

@andrewmitchellsemestry andrewmitchellsemestry merged commit e3f1620 into master Dec 6, 2022
@MikeN123 MikeN123 deleted the semestry-branch-update branch December 6, 2022 08:42
@MikeN123
Copy link

MikeN123 commented Dec 6, 2022

@johanwortel @andrewmitchellsemestry who will create a v1.2.0 tag and update the v1 tag?

@andrewmitchellsemestry
Copy link
Contributor Author

@MikeN123 I have added the new v1.2.0 tag and updated the v1 tag to be linked with the latest changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants