Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard docs #433

Merged
merged 4 commits into from
Feb 10, 2022
Merged

Dashboard docs #433

merged 4 commits into from
Feb 10, 2022

Conversation

s-santillan
Copy link
Collaborator

Security

  • Change has no security implications (otherwise, ping the security team)

@linear
Copy link

linear bot commented Feb 9, 2022

MKT-144 Document Semgrep App > Dashboard (overview) page

It seems this page isn’t documented: https://semgrep.dev/manage

We should document for example:

  • What is fix rate and how it’s calculated (including time frame)
  • What is “muted” (maybe this is already defined elsewhere?)

@s-santillan s-santillan marked this pull request as draft February 9, 2022 21:04
@s-santillan s-santillan marked this pull request as ready for review February 9, 2022 21:47
@s-santillan @raghavjain3
Update docs/semgrep-app/dashboard.md
9bf070e 
Co-authored-by: raghavjain3 <32291067+raghavjain3@users.noreply.github.com>
@s-santillan s-santillan enabled auto-merge (squash) February 9, 2022 23:54
@s-santillan s-santillan disabled auto-merge February 10, 2022 00:39
@s-santillan
Copy link
Collaborator Author

@adamboros Have updated the text to open findings cc @raghavjain3

@s-santillan s-santillan enabled auto-merge (squash) February 10, 2022 00:43
@s-santillan s-santillan requested a review from pabloest February 10, 2022 18:22
@s-santillan s-santillan merged commit 989a184 into main Feb 10, 2022
@s-santillan s-santillan deleted the sara/mkt-144-document-semgrep-app-dashboard-overview branch February 10, 2022 18:23
@s-santillan s-santillan self-assigned this Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raghavjain3 raghavjain3 raghavjain3 left review comments

@pabloest pabloest pabloest approved these changes

Assignees

@s-santillan s-santillan

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s-santillan @pabloest @raghavjain3