Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved Transaction into function newTransaction #12

Closed
wants to merge 1 commit into from

Conversation

carlosvdr
Copy link
Collaborator

No description provided.

@carlosvdr carlosvdr self-assigned this Nov 7, 2023
Signed-off-by: carlos.vdr <carlos.vdr@semiotic.ai>
Copy link
Contributor

@aasseman aasseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I'm not sure that moving everything related to Transaction into a function is really beneficial to readability.
Originally I was thinking that just moving new Transaction(... part would help with avoiding to to string manipulations every time.

@carlosvdr
Copy link
Collaborator Author

carlosvdr commented Nov 8, 2023

Not gonna lie I thought the same, its not actually helping, but thought just moving the string manipulation to a function wasn't making much a difference either @aasseman, so decided to move more to make more sense of having a function but now it looks like it was better before too

@aasseman
Copy link
Contributor

aasseman commented Nov 8, 2023

Not gonna lie I thought the same, its not actually helping, but thought just moving the string manipulation to a function wasn't making much a difference either @aasseman, so decided to move more to make more sense of having a function but now it looks like it was better before too

OK, perhaps let's close this one then?

@carlosvdr
Copy link
Collaborator Author

Closing this, not really necessary

@carlosvdr carlosvdr closed this Nov 9, 2023
@carlosvdr carlosvdr deleted the transaction-function branch November 9, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants