-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unassigned deposits #13
Conversation
Signed-off-by: carlos.vdr <carlos.vdr@semiotic.ai>
Signed-off-by: carlos.vdr <carlos.vdr@semiotic.ai>
Please help me review this PR, still need to add tests into the local tests. |
schema.graphql
Outdated
@@ -37,6 +37,13 @@ type Transaction @entity{ | |||
escrowAccount: EscrowAccount! | |||
} | |||
|
|||
type UnnasignedTransaction @entity{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than creating this new entity, would it be simpler if you just add an unassignedBalance field in the Sender entity? Or is there a reason why you'd prefer this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that does make sense, didnt thought of that thanks!
Signed-off-by: carlos.vdr <carlos.vdr@semiotic.ai>
Signed-off-by: carlos.vdr <carlos.vdr@semiotic.ai>
Signed-off-by: carlos.vdr <carlos.vdr@semiotic.ai>
Signed-off-by: carlos.vdr <carlos.vdr@semiotic.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (not sure why CI is failing tho)
Closing this as this changes were discarded |
No description provided.