Skip to content
This repository has been archived by the owner on Jun 24, 2024. It is now read-only.

feat: add fetch call to sql-studio-webapp when instancing ResultsProv… #8

Merged
merged 3 commits into from
Mar 20, 2024
Merged

feat: add fetch call to sql-studio-webapp when instancing ResultsProv… #8

merged 3 commits into from
Mar 20, 2024

Conversation

ricardo-rp
Copy link
Contributor

@ricardo-rp ricardo-rp commented Mar 19, 2024 •
edited
Loading

…ider

Closes STU-136

@ricardo-rp
Copy link
Contributor Author

Small proof of concept for fetching the endpoint from sql-studio webapp.
What should we do with the currently hardcoded endpoint? Should we keep it as a default, or should we block interaction queries while the endpoint is being fetched?

anirudh2
anirudh2 suggested changes Mar 19, 2024
View reviewed changes
Copy link
Member

@anirudh2 anirudh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple super minor things. Once you do them, feel free to merge!

src/providers/results.ts Outdated Show resolved Hide resolved
src/providers/results.ts Outdated Show resolved Hide resolved
@linear Linear
Copy link

linear bot commented Mar 20, 2024

STU-136 Create a command to replace an ID in a gsql file

@ricardo-rp ricardo-rp merged commit 274b861 into main Mar 20, 2024
14 checks passed
@ricardo-rp ricardo-rp deleted the feat/fetch-graphnode-endpoint branch March 20, 2024 11:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anirudh2 anirudh2 anirudh2 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricardo-rp @anirudh2