-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Huge cleanup (PHP 8 only; prep. for long term support) #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k00ni
added
enhancement
waiting for feedback
Waiting for essential feedback of one of the parties in the conversation.
labels
Aug 29, 2023
Absolutely fine with me. Thanks for still putting work into the library :-) |
k00ni
removed
the
waiting for feedback
Waiting for essential feedback of one of the parties in the conversation.
label
Aug 29, 2023
k00ni
added a commit
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Huge (with big H) cleanup of the code base to prepare it for long term support. In the following a summary of all major changes:
ARC2_Class::queryDB(...)
, because it relied on outdated mysqli usage.getServerInfo()
; changedgetServerVersion()
to use SQLselect version()
to get DB server versioncomposer.json
. For instance, removedsymfony/cache
.db_con
in ARC2 configuration was removed. It used to hold the mysqli connection.CC @semsol @bnowack What do you think? The library is barely used and didn't receive any updates since 2021. Because it is a dependency of my EasyRdf fork (https://github.com/sweetrdf/easyrdf), I want it to remain stable and somewhat working on newer PHP versions.
Merging this pull request will result in version 3 to be released ❗