Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc 1.0.39 #62

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Rc 1.0.39 #62

merged 4 commits into from
Aug 22, 2024

Conversation

semuadmin
Copy link
Contributor

pynmeagps Pull Request Template

Description

  1. Add support for NMEA data streams with lower case hexadecimal checksum chars.

Fixes #60

Testing

Please test all changes, however trivial, against the supplied pytest suite tests/test_*.py. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.

  • test added to test_stream.py

Checklist:

  • [x I agree to abide by the code of conduct (see CODE_OF_CONDUCT.md).
  • My code follows the style guidelines of this project (see CONTRIBUTING.md).
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain >= 99% code coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have signed my commits.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

@semuadmin semuadmin added the bug Something isn't working label Aug 22, 2024
@semuadmin semuadmin added this to the RC 1.0.39 milestone Aug 22, 2024
@semuadmin semuadmin self-assigned this Aug 22, 2024
@semuadmin semuadmin requested a review from a team August 22, 2024 21:55
@semuadmin semuadmin merged commit 758bc37 into master Aug 22, 2024
6 checks passed
@semuadmin semuadmin deleted the RC-1.0.39 branch August 22, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NMEAReader Checksum Validation Error
2 participants