Core: Revert to using ceil for 2/3 vote #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe @cryptokat can clarify, but doing a round here for initial blocks (2 validators), will allow for both to propose and accept disparate blocks. I'm not sure case where round was necessary over ceil, if that is the case we can just add a check where validators == 2 to fix.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe @cryptokat can clarify, but doing a round here for initial blocks
(2 validators), will allow for both to propose and accept disparate
blocks.
I'm not sure case where round was necessary over ceil, if that is the case
we can just add a check where validators == 2 to fix.
Note: merging this into RC3 then down to various PRs will fix CI that is failing.